-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed Setup Script Typo #1588
Fixed Setup Script Typo #1588
Conversation
This could fix a lot of installation issues that people have been facing. |
Can you explain what happens? Looks good to me, but want to be careful! |
Codecov Report
@@ Coverage Diff @@
## main #1588 +/- ##
=======================================
Coverage 66.61% 66.61%
=======================================
Files 130 130
Lines 2672 2672
Branches 430 430
=======================================
Hits 1780 1780
Misses 892 892 |
We want to run grunt build after the installation is complete. Also `$$` is
a typo.
…On Tue, 28 Jan, 2020, 9:42 PM Jeffrey Warren, ***@***.***> wrote:
Can you explain what happens? Looks good to me, but want to be careful!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1588?email_source=notifications&email_token=AIJI5HYB6T6OYGQHXHDC3HLRABKOXA5CNFSM4KMU24G2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKD5PPQ#issuecomment-579327934>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AIJI5H5OQVY6SOCKOXLV7G3RABKOXANCNFSM4KMU24GQ>
.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should solve many of the installation issues that we've been getting lately!
Fixes #0000 (<=== Replace
0000
with the Issue Number)Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
npm run test-all
@publiclab/is-reviewers
for help, in a comment belowIf tests do fail, click on the red
X
to learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Please make sure to get at least two reviews before asking for merging the PR as that would make the PR more reliable on our part
Thanks!